Navigation Screen: Update sidebar #31821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Navigation Screen
[Type] Enhancement
|
Size Change: +830 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
Mamaduka
requested review from
adamziel,
ajitbohra,
draganescu,
kevin940726,
nerrad,
noisysocks,
ntwb,
talldan and
tellthemachines
as code owners
|
I had few more changes in mind, mostly code quality, but decided to create separated PRs for an easy review process. |
getdave
reviewed
May 17, 2021
|
Thanks for catching this, @getdave The issue should be fixed now. Screenshot
|
getdave
reviewed
May 17, 2021
There was a problem hiding this comment.
Thank you for tackling this PR.
I can't decide about this one. On one hand it's great to have a space to put settings that are Navigation Editor specific rather than relying on filtering the core/navigation block to ad what we need.
On the other hand by never showing the core/navigation block's inspector controls we going to end up losing a lot of settings that come "out of the box" with the block.
Is there a way we can get the best of both world's? Looks like @shaunandrews had some good ideas with tabs in #30325 (comment).
This would make the screen a kin to the post editor where you have the idea of the "Post" and the "Block". We could have "Navigation" and "Block", defaulting to "Block".
If we want to auto select the core/navigation block when nothing is selected we can do akin to:
const { selectedBlock, allBlocks } = useSelect( ( select ) => {
return {
selectedBlock: select( blockEditorStore ).getSelectedBlock(),
allBlocks: select( blockEditorStore ).getBlocks(),
};
}, [] );
const { selectBlock } = useDispatch( blockEditorStore );
useEffect( () => {
if ( null === selectedBlock && allBlocks?.length ) {
selectBlock( allBlocks[ 0 ].clientId );
}
}, [ selectedBlock, allBlocks ] );Ultimately should we try to:
- Mirror patterns already established in the Post/Site Editor.
- Avoid losing the Block sidebar that comes with the
core/navigationblock.
I like the idea.
I think it makes more to have "Navigation" selected by default. This is where general navigation settings will live. Going to start working on updates. |
Mamaduka
changed the title
|
@getdave, the second iteration is ready for testing. |
getdave
approved these changes
May 18, 2021
There was a problem hiding this comment.
✅ This is a big improvement. There's now a clear distinction between the blocks and the wider concept of the menu. It also allows us to decouple controls that are unique to the Editor from the core/navigation block.
I tested this with various scenarios and couldn't find any obvious errors.
🚢 👏 👏 👏 👏
Mamaduka
force-pushed
the
try/nav-screen-general-sidebar
branch
2 times, most recently
from
d6bea7c to
56808ca
Compare
Mamaduka
force-pushed
the
try/nav-screen-general-sidebar
branch
from
56808ca to
00c1cad
Compare
|
👏 👏 👏 👏 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates sidebar to incorporate tabs for Menu and Block settings, as suggested by @shaunandrews #30325 (comment).
New design and UX are similar to sidebars of other editor screens.
Changes look a lot, but it's mostly moving components into a new directory.
Fixes #30325.
Fixes #31508.
How has this been tested?
Screenshots
CleanShot.2021-05-18.at.15.18.51.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).